Skip to content

chore: migrate buf-setup-action to buf-action for Node.js 24#1960

Merged
bjcoombs merged 2 commits intodevelopfrom
fix-buf-action-node24
Mar 26, 2026
Merged

chore: migrate buf-setup-action to buf-action for Node.js 24#1960
bjcoombs merged 2 commits intodevelopfrom
fix-buf-action-node24

Conversation

@bjcoombs
Copy link
Copy Markdown
Collaborator

@bjcoombs bjcoombs commented Mar 26, 2026

Summary

  • Replaces bufbuild/buf-setup-action@v1 with bufbuild/buf-action@v1 (with setup_only: true) across all 14 workflow files (27 occurrences)
  • buf-setup-action is pinned to Node.js 20, which GitHub Actions will deprecate on June 2, 2026
  • buf-action runs on Node.js 24 and supports setup_only mode as a drop-in replacement

Test plan

  • CI passes on this PR (the workflows themselves exercise the new action)
  • Proto generation still works (buf generate step succeeds)
  • No Node.js 20 deprecation warnings in CI annotations

@bjcoombs
chore: migrate buf-setup-action to buf-action for Node.js 24 support
61ddae1 
bufbuild/buf-setup-action is pinned to Node.js 20 which GitHub Actions
will deprecate on June 2, 2026. bufbuild/buf-action uses Node.js 24 and
supports setup_only mode as a drop-in replacement.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 26, 2026 •
edited
Loading

Warning

Rate limit exceeded

@bjcoombs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9ea9bc3b-15b2-4bf4-b8ae-efa2054c00c6

📥 Commits

Reviewing files that changed from the base of the PR and between 7dff219 and 62b3445.

📒 Files selected for processing (14)
  • .github/workflows/benchmarks.yml
  • .github/workflows/build.yml
  • .github/workflows/codeql.yml
  • .github/workflows/control-plane-ci.yml
  • .github/workflows/conventions.yml
  • .github/workflows/deploy-demo.yml
  • .github/workflows/deploy-develop.yml
  • .github/workflows/e2e.yml
  • .github/workflows/nightly.yml
  • .github/workflows/proto.yml
  • .github/workflows/quality.yml
  • .github/workflows/saga-validation.yml
  • .github/workflows/security.yml
  • .github/workflows/test.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-buf-action-node24

Comment @coderabbitai help to get the list of available commands and usage tips.

claude[bot]
claude Bot approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean mechanical replacement of bufbuild/buf-setup-action with bufbuild/buf-action (setup_only: true) across all 14 workflow files. Correct and consistent. No domain risks. See summary comment for details.

@claude
Copy link
Copy Markdown

claude Bot commented Mar 26, 2026 •
edited
Loading

Claude Code Review

Commit: 62b3445 | CI: running (Proto Validation + Proto Compilation passing)

Summary

Clean mechanical migration of bufbuild/buf-setup-action to bufbuild/buf-action with setup_only: true across all 14 workflow files. The replacement is consistent and correct. This addresses the upcoming Node.js 20 deprecation (June 2, 2026) by moving to Node.js 24.

Risk Assessment

Area Level Detail
Blast radius Low CI workflows only, no application code
Rollback Safe Single revert restores all workflows
Scale N/A No runtime impact
Cross-system Low Only affects buf CLI setup in CI
Migration N/A No database migrations

Findings

No issues found. The change is uniform across all files with the same pattern applied consistently.

Notes

  • codeql.yml previously pinned buf-setup-action@v1.50.0 and now uses buf-action@v1. Since this is a different action, the old version pin does not carry over. This is expected.
  • Proto Validation and Proto Compilation checks are already passing, confirming buf-action with setup_only: true correctly installs the buf CLI.
  • Remaining CI checks are still running and will validate the new action end-to-end.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@bjcoombs bjcoombs merged commit ff1cabf into develop Mar 26, 2026
31 of 32 checks passed
@bjcoombs bjcoombs deleted the fix-buf-action-node24 branch March 26, 2026 13:58
claude[bot]
claude Bot approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, consistent migration across all 14 workflow files. No issues found. See summary comment for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bjcoombs